1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85

module Check.AST.Pattern.EqualsEmptyList where

import Curry.SpanInfo
import Curry.Span
import Curry.Position
import Curry.Types
import Curry.Ident
import Text.Pretty

import Types

-- check for infix operation and function with two parameters
checkEqualsEmptyList :: Expression a -> Int -> CSM ()
checkEqualsEmptyList e _ = case e of
  (InfixApply
    _
    _
    (InfixOp _
      (QualIdent _ _
        (Ident _ _ _)))
    _)
    -> checkInfix e
  (Apply _
    (Apply _
      (Variable _ _
        (QualIdent _ _
          (Ident _ _ _)
        )
      )
      _)
    _)
    -> checkApply e
  _ -> return ()

-- if compared with [] use function null instead
checkInfix :: Expression a -> CSM ()
checkInfix e =
  case checkInfixCompare e of
    (sI, _, "==", (List _ _ []))
      -> report (Message
                  (getSpan sI)
                  (text "Do not use" <+> colorizeKey "a == []")
                  (text "Use" <+> colorizeKey "null a" <+> text "instead"))
    (sI, (List _ _ []), "==",  _)
      -> report (Message
                  (getSpan sI)
                  (text "Do not use" <+> colorizeKey "[] == a")
                  (text "Use" <+> colorizeKey "null a" <+> text "instead"))
    (sI, (List _ _ []), "/=",  _)
      -> report (Message
                  (getSpan sI)
                  (text "Do not use" <+> colorizeKey "[] /= a")
                  (text "Use" <+> colorizeKey "not (null a)" <+> text "instead"))
    (sI, _, "/=", (List _ _ []))
      -> report (Message
                  (getSpan sI)
                  (text "Do not use" <+> colorizeKey "a /= []")
                  (text "Use" <+> colorizeKey "not (null a)" <+> text "instead"))
    _ -> return ()

-- if compared with [] use function null instead
checkApply :: Expression a -> CSM ()
checkApply e =
  case checkApplyCompare e of
    (sI, "==", _ , (List _ _ []))
      -> report (Message
                  (getSpan sI)
                  (text "Do not use" <+> colorizeKey "(==) a []")
                  (text "Use" <+> colorizeKey "null a" <+> text "instead"))
    (sI, "==", (List _ _ []), _)
      -> report (Message
                  (getSpan sI)
                  (text "Do not use" <+> colorizeKey "(==) [] a")
                  (text "Use" <+> colorizeKey "null a" <+> text "instead"))
    (sI, "/=", (List _ _ []), _)
      -> report (Message
                  (getSpan sI)
                  (text "Do not use" <+> colorizeKey "(/=) [] a")
                  (text "Use" <+> colorizeKey "not (null a)" <+> text "instead"))
    (sI, "/=", _, (List _ _ []))
      -> report (Message
                  (getSpan sI)
                  (text "Do not use" <+> colorizeKey "(/=) a []")
                  (text "Use" <+> colorizeKey "not (null a)" <+> text "instead"))
    _ -> return ()